-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Image Generation support using Imagen #8683
base: main
Are you sure you want to change the base?
Conversation
|
c1d397f
to
ec35231
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just some nits (mostly about doc formatting) and small questions.
addWatermark?: boolean; | ||
safetyFilterLevel?: string; | ||
personGeneration?: string; | ||
includeRaiReason: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We put the word "rai" in the parameter going up but we remove it in the response? I can see reasons for including or not including but it should be consistent I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This property is not user-facing.
Users define configurations in ImagenGenerationConfig
and ImagenModelParams
, and these interfaces do not define a parameter related to the RAI reason- users cannot disable this. These configurations get mapped to this PredictRequestBody
interface which is internal. Here, we set includeRaiReason
to always be true, since users cannot define it in the config.
The flow looks like:
User --> ImagenGenerationConfig
& ImagenModelParams
--> PredictRequestBody
(includeRaiReason: true
)--> HTTP request --> HTTP response --> ImagenResponseInternal
(raiFilteredReason: ...
) --> ImagenImageResponse
(filteredReason: ...
) --> User
…se-js-sdk into dl/vertex-imagen
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
WIP