Hanabi1224 upgrade deps #1770
Hanabi1224 upgrade deps #1770
Conversation
fix: all required clippy updates
|
Looks like the MacOS runners are broken (failure to download parameters). I may disable that as required for now, but if someone wants to take a look at what could get them going again, please do |
Marking them as non required is a good idea (I would mark none of the tests as required, in the past it's been causing more issues than good). Once this PR lands, I will retrigger the parameter generation job, which should then make the MacOS ones work again. |
| @@ -1,3 +1,5 @@ | |||
| println!("cargo::rustc-check-cfg=cfg(nightly)"); | |||
There was a problem hiding this comment.
I'm surprised it works. I would put it into the main().
| @@ -563,6 +563,7 @@ need to handle the potential bit-level misalignments: | |||
| // offset and num_bytes are based on the unpadded data, so | |||
| // if [0, 1, ..., 255] was the original unpadded data, offset 3 and len 4 would return | |||
| // [3, 4, 5, 6]. | |||
| #[allow(clippy::multiple_bound_locations)] | |||
There was a problem hiding this comment.
Instead of adding a Clippy exception, I'd put the ?Sized to the W: Write as W: Write + Sized.
| @@ -630,6 +631,7 @@ The reader will generally operate with bit precision, even if the padded | |||
| layout is byte-aligned (no extra bits) the data inside it isn't (since | |||
| we pad at the bit-level). | |||
| **/ | |||
| #[allow(clippy::multiple_bound_locations)] | |||
There was a problem hiding this comment.
Same as the comment on line 566.
| @@ -316,6 +316,7 @@ pub fn select<Scalar: PrimeField, CS: ConstraintSystem<Scalar>>( | |||
| } | |||
|
|
|||
| /// Takes two allocated numbers (`a`, `b`) and returns `a` if the condition is true, and `b` otherwise. | |||
| #[allow(clippy::multiple_bound_locations)] | |||
There was a problem hiding this comment.
Instead of this Clippy exception, I'd just remove the whole
where
CS: ConstraintSystem<Scalar>,as it's redundant anyway.
| @@ -8,4 +8,6 @@ fn cfg_if_nightly() { | |||
| } | |||
|
|
|||
| #[rustversion::not(nightly)] | |||
| fn cfg_if_nightly() {} | |||
| fn cfg_if_nightly() { | |||
| println!("cargo::rustc-check-cfg=cfg(nightly)"); | |||
There was a problem hiding this comment.
I'm not sure if it's correct. I would put print it in all cases, hence put this line into main() instead.
This is a replacement of #1767 (PR moved to this repo)