-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: release Lotus node v1.31.0-rc1 #12693
Conversation
build: release Lotus node v1.31.0-rc1
chore: update changelog for v1.31.0-rc1
Update CHANGELOG.md Update CHANGELOG.md Co-Authored-By: Steve Loeppky <[email protected]>
f37b175
to
b703634
Compare
chore: update changelog formatting
- `lotus-shed indexes inspect-indexes` now performs a comprehensive comparison of the event index data for each message by comparing the AMT root CID from the message receipt with the root of a reconstructed AMT. Previously `inspect-indexes` simply compared event counts, comparing AMT roots confirms all the event data is byte-perfect. ([filecoin-project/lotus#12570](https://github.com/filecoin-project/lotus/pull/12570)) | ||
- Expose APIs to list the miner IDs that are currently participating in F3 via node. ([filecoin-project/lotus#12608](https://github.com/filecoin-project/lotus/pull/12608)) | ||
- Implement new `lotus f3` CLI commands to list F3 participants, dump manifest, get/list finality certificates and check the F3 status. ([filecoin-project/lotus#12617](https://github.com/filecoin-project/lotus/pull/12617), [filecoin-project/lotus#12627](https://github.com/filecoin-project/lotus/pull/12627)) | ||
- Return a `"data"` field on the `"error"` returned from RPC when `eth_call` and `eth_estimateGas` APIs encounter `execution reverted` errors. ([filecoin-project/lotus#12553](https://github.com/filecoin-project/lotus/pull/12553)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rjan90 what's the criteria for what makes it into the changelog and what's dropped? I went to the changelog today to see whether this particular item was included in 1.31 so I could point someone to it (for #12737) but it's not there so I had to go git log
digging to figure it out. Same with the lotus f3
one above it which has been dropped. Is it just a matter of picking highlights and removing the cruft that's not worth highlighting? I imagined that the skip/changelog
tag mostly helped us with that at time of merge. But maybe I need to be paying more attention to these PRs.
On the flip side, lotus-shed indexes inspect-indexes
is now irrelevant because the file that was introduced into has been deleted because of ChainIndexer .. ooops, we probably should have dropped that line in the changelog, or just not backported.
Related Issues
#12344
Proposed Changes
build: release Lotus node & miner v1.31.0-rc1
Checklist
Before you mark the PR ready for review, please make sure that: