-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: used new parent relation on instanceof control for has one through #15265
Fix: used new parent relation on instanceof control for has one through #15265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would break Laravel 10.x compatibility, right? Can you do a class_exists()
check and check the correct parent class based on that please?
@danharrin I've added the check you have mentioned above |
@danharrin I also realized that |
Please can you do the |
Done! @danharrin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the return type of getRelationship()
need updating? Any other references to this class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we did, I think we would need to retain both HasManyThrough
and HasOneOrManyThrough
on the return type for backwards compatibility, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I fixed that too.
Thanks |
Description
fix for the issue I created. CreateAction is checking the correct class on instance of control now.