Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x throw exception if relationship is not found #14334

Open
wants to merge 9 commits into
base: 4.x
Choose a base branch
from
Open

4.x throw exception if relationship is not found #14334

wants to merge 9 commits into from

Conversation

howdu
Copy link
Contributor

@howdu howdu commented Sep 24, 2024

Description

Throw a helpful exception message instead of:
Screenshot_2024-09-12_at_18 25 51

Visual changes

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@zepfietje zepfietje added the enhancement New feature or request label Sep 26, 2024
@zepfietje zepfietje modified the milestones: v3, v4 Sep 26, 2024
danharrin
danharrin requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please apply this on other form components that have a relationship() method?

@howdu howdu requested a review from danharrin December 9, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danharrin danharrin Awaiting requested review from danharrin

Requested changes must be addressed to merge this pull request.

Assignees

@danharrin danharrin

Labels
awaiting next major version enhancement New feature or request
Projects
Roadmap
Status: In Progress
Milestone
v4
Development

Successfully merging this pull request may close these issues.
3 participants
@howdu @danharrin @zepfietje