Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error typos and introduce error types #143

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

dhaus67
Copy link
Contributor

@dhaus67 dhaus67 commented Oct 15, 2024

Noticed some typos in some error messages and fixed those.

Additionally, one of the common things I'd like to do when cleaning up is e.g. react properly on the "server has not been started" error. While that's possible by doing error message comparison, it would be nice exporting a type for both the start and stop cases similar to e.g. the net/http library.

@dhaus67 dhaus67 changed the title fix: error types and introduce error types fix: error typos and introduce error types Oct 15, 2024
@fergusstrange
Copy link
Owner

Thanks for this @dhaus67, this is a great improvement.

@fergusstrange fergusstrange merged commit 9ff0024 into fergusstrange:master Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants