Allow after_build_id to be empty #1067
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Feb 7, 2025
Stop using variable after_build_id in order to fix a non-issue reported by shellcheck. We now assume that env.packages stores a single package. This has been true for the past months. Fixes: 68b3e36 (Introduce github action linting in pre-commit, 2025-02-05)
|
@nikic Makes sense. I've just incorporated that suggestion to this PR. |
|
Closed in favor of #1069 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop quoting after_build_id in order to use it even when it's empty. Disable shellcheck error reporting on this.