command config #26
Merged
command config #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
reviewed
Jun 14, 2019
|
I don't understand the question. Essentially we cannot ask via command line flags for values, because those might be sensitive information (a token) that will end up in the user sh history :/. So, the solution is to use a prompt. |
mcollina
reviewed
Aug 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #23 and #3
Relates to #2
Starting to design how to store the common config.
The idea is to introduce a config command that consent to users to store the key/value pair they use often and then load those settings when the other commands will execute.
Another aspect is to lock some keys, like
--majorand--npm-otp.The config will be stored in
~/releasifydirectory and not in clear textLet me know your considerations 👍