Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for submodules #55

Closed
wants to merge 1 commit into from
Closed

Fix support for submodules #55

wants to merge 1 commit into from

Conversation

mohd-akram
Copy link

Closes #15

Checklist

@mcollina mcollina requested a review from jsumners July 13, 2022 14:27
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

@mohd-akram
Copy link
Author

Not sure how to go about this...there don't seem to be any tests for the install script.

@mohd-akram
Copy link
Author

Any update on this?

@jsumners
Copy link
Member

I'd like to see a test. An integration test is acceptable.

@mohd-akram mohd-akram closed this Jul 25, 2022
@Uzlopak
Copy link
Contributor

Uzlopak commented Jul 25, 2022

@mohd-akram

Dont get me wrong: Did you close this because you dont want to provide a test?

@mohd-akram
Copy link
Author

This is not that big of a priority for me, and I'm not currently using this fork (I'm using the original pre-commit module but that isn't maintained). Someone has to figure out how to add install tests to the repo and integrate it with the CI.

@Uzlopak Uzlopak mentioned this pull request Jul 26, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support git-submodules
3 participants