Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP]--Support for Material Attributes using GLTF format. #1762

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

[WIP]--Support for Material Attributes using GLTF format. #1762

wants to merge 6 commits into from
+1,124 −40

Conversation

jturner65
Copy link
Contributor

Motivation and Context

This PR adds a Material Attributes/Manager in Habitat that follows the GLTF 2.0 format for materials and allows per-scene instance specification of materials, as well as material editing capabilities as per the existing Attributes/Managers paradigm.

This is still a WIP.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jturner65 jturner65 requested a review from aclegg3 May 25, 2022 19:26
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 25, 2022
@jturner65 jturner65 force-pushed the MaterialAttr branch 3 times, most recently from f95f61b to 69f5372 Compare February 22, 2023 16:53
@jturner65 jturner65 force-pushed the MaterialAttr branch 5 times, most recently from c9ca156 to 31d4cde Compare April 5, 2023 15:50
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from 51e9e3c to 571c844 Compare April 13, 2023 13:27
@jturner65 jturner65 force-pushed the MaterialAttr branch 3 times, most recently from 6c57aee to b86cb09 Compare April 24, 2023 21:43
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from 0a6f485 to d824d6c Compare October 12, 2023 13:29
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from 346a440 to cd479a7 Compare November 17, 2023 12:48
@jturner65 jturner65 force-pushed the MaterialAttr branch 3 times, most recently from e0b264a to 1f98c21 Compare November 29, 2023 18:42
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from 7265d76 to aa9c230 Compare December 7, 2023 14:20
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from a7a2837 to 25c6c2e Compare May 13, 2024 18:48
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from a471efd to d39c388 Compare June 18, 2024 13:53
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from 65e97e7 to 823cd8d Compare July 25, 2024 15:29
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from 42f84e3 to b7538b4 Compare August 25, 2024 15:49
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from 42a69df to d34ced0 Compare September 5, 2024 12:59
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from cb99c7e to fa71e07 Compare September 18, 2024 17:19
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from a521cb8 to 59a8e99 Compare November 4, 2024 18:19
@jturner65 jturner65 force-pushed the MaterialAttr branch 3 times, most recently from 264c44d to f1ba9c6 Compare November 13, 2024 19:57
@jturner65 jturner65 force-pushed the MaterialAttr branch 2 times, most recently from e680aae to ddb0ae0 Compare December 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aclegg3 aclegg3 Awaiting requested review from aclegg3

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jturner65 @facebook-github-bot