Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin-react-hooks): "additionalHooks" docs are misleading #29046

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

StyleShit
Copy link
Contributor

Summary

This PR closes #29045
It aims to improve the documentation by fixing the regex to match only the necessary hooks, and also adds some tests to cover those cases.

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 11:11am

@react-sizebot
Copy link

react-sizebot commented May 17, 2024

Comparing: 7f217d1...15d6b47

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.82 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.46 kB 501.46 kB = 89.98 kB 89.98 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 506.28 kB 506.28 kB = 90.68 kB 90.68 kB
facebook-www/ReactDOM-prod.classic.js = 598.90 kB 598.90 kB = 105.77 kB 105.77 kB
facebook-www/ReactDOM-prod.modern.js = 575.01 kB 575.01 kB = 102.01 kB 102.01 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 982f88e

Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Oct 24, 2024
@StyleShit
Copy link
Contributor Author

Bump

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Oct 24, 2024
Copy link

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Jan 22, 2025
@StyleShit
Copy link
Contributor Author

Bump

@github-actions github-actions bot removed the Resolution: Stale Automatically closed due to inactivity label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: eslint-plugin-react-hooks documentation might be misleading
3 participants