Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve implementation #399

Closed
wants to merge 10 commits into from
Closed

Improve implementation #399

wants to merge 10 commits into from

Conversation

w-masahiro-ct
Copy link
Contributor

@w-masahiro-ct w-masahiro-ct commented Jan 18, 2025 •
edited
Loading

What's changed

  • Update .gitignore
  • Bundle update
  • Improve gemspec (for spec.files)
  • Update ruby version to 2.7 in .rubocop.yml to keep in sync with .circleci/config.yml and gemspec
  • Install "rubocop-minitest", "rubocop-performance", "rubocop-rake"
  • Update .rubocop.yml
  • Refactor for rubocop
  • Fix bad practice that overrides String class
  • Update test gems and tests
  • Replace from CircleCI to GitHubActions

@w-masahiro-ct w-masahiro-ct force-pushed the improve-implementation branch 9 times, most recently from 3ebb325 to 796f8bb Compare January 23, 2025 15:18
@w-masahiro-ct w-masahiro-ct force-pushed the improve-implementation branch from 796f8bb to d733cf8 Compare January 23, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@w-masahiro-ct