Save image to buffer #1105
Merged
Save image to buffer #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are modifying libf3d public API! |
mwestphal
reviewed
Dec 18, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1105 +/- ##
=======================================
Coverage 96.43% 96.44%
=======================================
Files 124 124
Lines 7693 7713 +20
=======================================
+ Hits 7419 7439 +20
Misses 274 274 ☔ View full report in Codecov by Sentry. |
|
related to #1101 as well I think |
|
Yes, that's the libf3d fix for this issue as well. We'll need to implement the application functionality too. |
snoyer
reviewed
Dec 18, 2023
snoyer
reviewed
Dec 18, 2023
mwestphal
reviewed
Dec 18, 2023
snoyer
reviewed
Dec 19, 2023
Meakk
force-pushed
the
save-buffer
branch
2 times, most recently
from
1d5dd4e to
f3737d9
Compare
snoyer
reviewed
Dec 19, 2023
mwestphal
approved these changes
Dec 19, 2023
aemreaydin
pushed a commit
to aemreaydin/f3d
that referenced
this pull request
Dec 19, 2023
mwestphal
pushed a commit
that referenced
this pull request
Feb 10, 2024
mwestphalnew
pushed a commit
to mwestphalnew/f3d
that referenced
this pull request
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1104