Reimplement test case in DnD Character #2338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reimplements test case 2ca77b9b-c099-46c3-a02c-0d0f68ffa0fe in the DnD Character exercise to verify that *every* ability is calculated only once, instead of only the `strength` ability.
sanderploegsma
force-pushed
the
dnd-character-reimplement-2ca77b9b-c099-46c3-a02c-0d0f68ffa0fe
branch
from
3bac331 to
94ee165
Compare
|
I can't get the "Check links" CI job to succeed, looks like web.archive.org is having some trouble. |
|
Links appear to be working now. I'd suggest forcing the CI to rerun. |
IsaacG
approved these changes
Nov 17, 2023
BethanyG
approved these changes
Nov 17, 2023
meatball133
approved these changes
Nov 17, 2023
sanderploegsma
deleted the
dnd-character-reimplement-2ca77b9b-c099-46c3-a02c-0d0f68ffa0fe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reimplements test case
2ca77b9b-c099-46c3-a02c-0d0f68ffa0fein the DnD Character exercise to verify that every ability is calculated only once, instead of only thestrengthability.This change was proposed in exercism/java#2548 and it made sense to me to add it to the canonical data.