-
-
Notifications
You must be signed in to change notification settings - Fork 627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note in the instructions.append.md #1570
Conversation
Dear asadrjhkThank you for contributing to the JavaScript track on Exercism! 💙
Dear Reviewer/Maintainer
Automated comment created by PR Commenter 🤖. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I left some comments how to make the addition adhere to the guidelines we have.
@@ -1,3 +1,6 @@ | |||
# Instructions append | |||
|
|||
It is possible to return a correct value for this exercise by mutating the solution function argument. Although there are legitimate use cases for mutating function arguments, this is usually undesirable, and in the case of this exercise, clearly unexpected. For this reason, the test suite has a test that fails in case the argument has been modified after the function execution. | |||
|
|||
## Notes | |||
The input and output of the gigasecond function is of type [Date](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Put your two new lines before line 3. Line 3 is also a note but yours is more important.
- Wrap
gigasecond
in backticks, see https://exercism.org/docs/building/markdown/markdown#h-code - See https://exercism.org/docs/building/markdown/markdown#h-links for how we provide links in the markdown
Currently, the CI pipeline fails because the formatting is not right. See https://github.com/exercism/javascript/blob/main/CONTRIBUTING.md#format for how to run the formatter.
sorry, about that but this time i try to make the PR using my local system, which makes the new pull request, i think i need to close this. |
Add a note in the instructions.append.md file that the input and output of the gigasecond function is of type Date.
closes #1564