Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak test generator documentation #497

Merged
merged 20 commits into from
Apr 18, 2024
Merged

Conversation

ErikSchierboom
Copy link
Member

@ErikSchierboom ErikSchierboom commented Apr 17, 2024

Tweak test generators docs

Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working it over. Looks great to me.

building/tooling/test-generators.md Outdated Show resolved Hide resolved
building/tooling/test-generators.md Outdated Show resolved Hide resolved
building/tooling/test-generators.md Outdated Show resolved Hide resolved
building/tooling/test-generators.md Outdated Show resolved Hide resolved
##### Nesting

Some exercises use nesting, where `cases` are nested in other `cases` keys.
Only the innermost (leaf) `cases` will actually have any test cases, their parent `cases` will only ever be used for grouping.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the case. It may have been a design goal, but it isn't in reality. See e.g. https://github.com/exercism/problem-specifications/blob/main/exercises/binary-search-tree/canonical-data.json

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I stand corrected! I've updated.

building/tooling/test-generators.md Outdated Show resolved Hide resolved
building/tooling/test-generators.md Outdated Show resolved Hide resolved
building/tooling/test-generators.md Outdated Show resolved Hide resolved
building/tracks/new/implement-tooling.md Outdated Show resolved Hide resolved
building/tooling/README.md Outdated Show resolved Hide resolved
building/tooling/test-generators.md Outdated Show resolved Hide resolved
@ErikSchierboom ErikSchierboom merged commit 1ac8bd2 into main Apr 18, 2024
@ErikSchierboom ErikSchierboom deleted the test-generators-tweaks branch April 18, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants