Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add asSet #173

Merged
merged 2 commits into from
May 20, 2024
Merged

Add asSet #173

merged 2 commits into from
May 20, 2024

Conversation

noamokman
Copy link
Contributor

Hey,
I wanted to add a new asSet accessor.
Let me know if we need any more changes.
Thanks!

evanshortiss
evanshortiss requested changes May 17, 2024
View reviewed changes
Copy link
Owner

@evanshortiss evanshortiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! I have some minor requests to get addressed before merging :)

test/types/index.ts Outdated Show resolved Hide resolved
yarn.lock Outdated Show resolved Hide resolved
test/index.js Show resolved Hide resolved
@noamokman
Copy link
Contributor Author

Thanks for the review 🙏🏻

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling a366991 on noamokman:add-as-set
into d900b9f on evanshortiss:master.

@evanshortiss evanshortiss merged commit e293285 into evanshortiss:master May 20, 2024
5 checks passed
@noamokman noamokman deleted the add-as-set branch May 21, 2024 04:52
@deboranreis deboranreis mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evanshortiss evanshortiss evanshortiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noamokman @coveralls @evanshortiss