Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ca, ca_CAT instances #47

Merged
merged 2 commits into from
Jul 12, 2020
Merged

ca, ca_CAT instances #47

merged 2 commits into from
Jul 12, 2020

Conversation

etspaceman
Copy link
Owner

@etspaceman etspaceman commented Jul 12, 2020

Changes Introduced

Introduced ca, ca_CAT instances. Also added tests for the en instances.

Applicable linked issues

#8

Checklist (check all that apply)

  • This change maintains backwards compatibility
  • I have introduced tests for all new features and changes
  • I have added documentation covering all new features and changes
  • This pull-request is ready for review

@codecov
Copy link

codecov bot commented Jul 12, 2020

Codecov Report

Merging #47 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   99.01%   99.02%           
=======================================
  Files          87       87           
  Lines         609      613    +4     
=======================================
+ Hits          603      607    +4     
  Misses          6        6           
Impacted Files Coverage Δ
src/main/scala/faker/Faker.scala 97.79% <ø> (ø)
src/main/scala/faker/ResourceLoader.scala 100.00% <ø> (ø)
src/main/scala/faker/StringGenBuilder.scala 100.00% <100.00%> (ø)
src/main/scala/faker/SupportedLocales.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab25165...090ae45. Read the comment docs.

@etspaceman etspaceman merged commit 1bcfead into master Jul 12, 2020
@etspaceman etspaceman deleted the ca branch July 12, 2020 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant