Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en_NZ instances #36

Merged
merged 2 commits into from
Jul 10, 2020
Merged

en_NZ instances #36

merged 2 commits into from
Jul 10, 2020

Conversation

etspaceman
Copy link
Owner

@etspaceman etspaceman commented Jul 10, 2020

Changes Introduced

Added en_NZ instances

Applicable linked issues

#8

Checklist (check all that apply)

  • This change maintains backwards compatibility
  • I have introduced tests for all new features and changes
  • I have added documentation covering all new features and changes
  • This pull-request is ready for review

@codecov
Copy link

codecov bot commented Jul 10, 2020

Codecov Report

Merging #36 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #36   +/-   ##
=======================================
  Coverage   98.82%   98.82%           
=======================================
  Files          87       87           
  Lines         594      595    +1     
  Branches        1        1           
=======================================
+ Hits          587      588    +1     
  Misses          7        7           
Impacted Files Coverage Δ
src/main/scala/faker/Faker.scala 97.79% <ø> (ø)
src/main/scala/faker/ResourceLoader.scala 92.30% <ø> (ø)
src/main/scala/faker/SupportedLocales.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e441ff...3fea196. Read the comment docs.

@etspaceman etspaceman merged commit 5b6e79b into master Jul 10, 2020
@etspaceman etspaceman deleted the en_NZ branch July 10, 2020 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant