Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

en_AU instances, using StringGenBuilder in State classes #32

Merged
merged 4 commits into from
Jul 9, 2020
Merged

Conversation

etspaceman
Copy link
Owner

@etspaceman etspaceman commented Jul 9, 2020

Changes Introduced

  • en_AU (Australia) instances introduced
  • StateLike classes updated to use a StringGenBuilder on zips for more flexibility

Applicable linked issues

Some progress towards #8

Checklist (check all that apply)

  • This change maintains backwards compatibility
  • I have introduced tests for all new features and changes
  • I have added documentation covering all new features and changes
  • This pull-request is ready for review

@etspaceman etspaceman added the feature New feature or request label Jul 9, 2020
@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #32 into master will increase coverage by 1.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
+ Coverage   97.50%   98.80%   +1.30%     
==========================================
  Files          87       87              
  Lines         602      588      -14     
  Branches        1        1              
==========================================
- Hits          587      581       -6     
+ Misses         15        7       -8     
Impacted Files Coverage Δ
src/main/scala/faker/Faker.scala 97.79% <ø> (-0.08%) ⬇️
src/main/scala/faker/ResourceLoader.scala 92.30% <ø> (+33.21%) ⬆️
src/main/scala/faker/SupportedLocales.scala 100.00% <100.00%> (ø)
src/main/scala/faker/address/StateLike.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f47f1...aeae4a5. Read the comment docs.

@etspaceman etspaceman merged commit cdc4e71 into master Jul 9, 2020
@etspaceman etspaceman deleted the en_AU branch July 9, 2020 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant