Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add en_IND instances, test refactor, State refactor #31

Merged
merged 3 commits into from
Jul 8, 2020
Merged

Conversation

etspaceman
Copy link
Owner

@etspaceman etspaceman commented Jul 8, 2020

Changes Introduced

  • Adds en_IND instances
  • Refactors tests to allow some locales to be skipped in some tests
  • Refactors State to be StateLike, adds Province, State and UsState instances. No longer US specific.

Is not backwards compatible due to the StateLike changes.

Applicable linked issues

Makes progress towards #8

Checklist (check all that apply)

  • This change maintains backwards compatibility
  • I have introduced tests for all new features and changes
  • I have added documentation covering all new features and changes
  • This pull-request is ready for review

@etspaceman etspaceman added the feature New feature or request label Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #31 into master will decrease coverage by 1.12%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   98.63%   97.50%   -1.13%     
==========================================
  Files          86       87       +1     
  Lines         587      602      +15     
  Branches        2        1       -1     
==========================================
+ Hits          579      587       +8     
- Misses          8       15       +7     
Impacted Files Coverage Δ
src/main/scala/faker/ResourceLoader.scala 59.09% <0.00%> (-30.91%) ⬇️
src/main/scala/faker/Faker.scala 97.86% <100.00%> (+0.01%) ⬆️
src/main/scala/faker/StringGenBuilder.scala 100.00% <100.00%> (ø)
src/main/scala/faker/SupportedLocales.scala 100.00% <100.00%> (ø)
src/main/scala/faker/address/StateLike.scala 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c35da9...6a76847. Read the comment docs.

@etspaceman etspaceman merged commit 80f47f1 into master Jul 8, 2020
@etspaceman etspaceman deleted the en_IND branch July 8, 2020 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant