Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add en_CA instances, StringRegexPart #18

Merged
merged 9 commits into from
Jul 6, 2020
Merged

Add en_CA instances, StringRegexPart #18

merged 9 commits into from
Jul 6, 2020

Conversation

etspaceman
Copy link
Owner

@etspaceman etspaceman commented Jul 6, 2020

Changes Introduced

Adds support for the en_CA Locale.

Applicable linked issues

Makes progress towards #8

Checklist (check all that apply)

  • This change maintains backwards compatibility
  • I have introduced tests for all new features and changes
  • I have added documentation covering all new features and changes
  • This pull-request is ready for review

@codecov
Copy link

codecov bot commented Jul 6, 2020

Codecov Report

Merging #18 into master will decrease coverage by 0.18%.
The diff coverage is 89.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   99.37%   99.18%   -0.19%     
==========================================
  Files          86       86              
  Lines         477      491      +14     
==========================================
+ Hits          474      487      +13     
- Misses          3        4       +1     
Impacted Files Coverage Δ
src/main/scala/faker/ResourceLoader.scala 89.47% <85.71%> (-10.53%) ⬇️
src/main/scala/faker/Faker.scala 97.89% <100.00%> (+0.02%) ⬆️
src/main/scala/faker/StringGenBuilder.scala 100.00% <100.00%> (ø)
src/main/scala/faker/syntax/string.scala 100.00% <100.00%> (ø)
...main/scala/faker/internet/PrivateIpV4Address.scala 100.00% <0.00%> (+8.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53a4d7c...77de03f. Read the comment docs.

@etspaceman etspaceman merged commit 5e59208 into master Jul 6, 2020
@etspaceman etspaceman deleted the en_CA branch July 6, 2020 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant