Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce Faker Class, implicit ResourceLoader #10

Merged
merged 8 commits into from
Jul 3, 2020
Merged

Introduce Faker Class, implicit ResourceLoader #10

merged 8 commits into from
Jul 3, 2020

Conversation

etspaceman
Copy link
Owner

@etspaceman etspaceman commented Jul 2, 2020 •
edited
Loading

Changes Introduced

  • Introduced a Faker class, which behaves similarly to java Faker's class.
  • Refactored ResourceLoader so that users can pass in different locales if desired
  • Made several public for sharing purposes

This PR breaks backwards compatibility and thus should be released as a Major release.

Applicable linked issues

Solves #9 and makes progress towards #8

Checklist (check all that apply)

  • This change maintains backwards compatability
  • I have introduced tests for all new features and changes
  • I have added documentation covering all new features and changes
  • This pull-request is ready for review

@etspaceman etspaceman changed the title Introduce Faker Class, implicit ResourceLoader [WIP] Introduce Faker Class, implicit ResourceLoader Jul 2, 2020
@etspaceman etspaceman changed the title [WIP] Introduce Faker Class, implicit ResourceLoader Introduce Faker Class, implicit ResourceLoader Jul 2, 2020
@etspaceman etspaceman merged commit b6e2754 into master Jul 3, 2020
@etspaceman etspaceman deleted the fakerClass branch July 3, 2020 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@etspaceman