Raise when any records are invalid

[pabloconde]

Changes Introduced

Raise error when there is at least one invalid record. Previously it was only raising when there was at least one failed record.

Applicable linked issues

Checklist (check all that apply)

• This change maintains backwards compatibility
• I have introduced tests for all new features and changes
• I have added documentation covering all new features and changes
• This pull-request is ready for review

[pabloconde]

This is a change in behaviour. Before, you would only see invalid records if there was at least one failed record also. Does this change align with the documentation?

kinesis4cats/docs/smithy4s/getting-started.md

Line 149 in 0e08701

A user can configure the producer to raise an exception if any of the error paths are detected (including partially failed records).

kinesis4cats/shared/src/main/scala/kinesis4cats/producer/Producer.scala

Lines 370 to 373 in 0e08701

	* @param raiseOnFailures
	* If true, an exception will be raised if a
	* [[kinesis4cats.producer.Producer.Error Producer.Error]] is detected in
	* one of the batches

[etspaceman]

Appreciate the PR, though I don't know if this is something we want to do. Raising an error on the I/O to Kinesis is what is important here. The return type of the put method allows for a user to handle their invalid records in any way they see fit. I'm not sure it makes sense to couple the 2.

[pabloconde]

Appreciate the PR, though I don't know if this is something we want to do. Raising an error on the I/O to Kinesis is what is important here. The return type of the put method allows for a user to handle their invalid records in any way they see fit. I'm not sure it makes sense to couple the 2.

Thanks for the feedback—I completely understand your point. My only concern here is that, if all records are invalid, the producer will not surface any error, which could be a bit unexpected from a user perspective, because invalid records are currently raised if there is also a failure in the batch. Just wanted to bring that up in case it aligns with the intended design.

[etspaceman]

Sorry for the long wait on this one. I see what you mean - this would only be done if configured. Makes sense.

[etspaceman]

Suggested change

	fixture(aggregate = true, raiseOnFailures = true).test(
	fixture(aggregate = true, raiseOnFailures = false).test(

I think we want this as false, yes?