Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated GPT mainnet chainID #6718

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

arpitkarnatak
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Feb 3, 2025

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot delete chains - only mark them deprecated. This is important to prevent replay attacks

@arpitkarnatak
Copy link
Contributor Author

@ligi Thank you for highlighting this. We've moved our chain to a new ChainID (111222333) and it's running on the same URLs as our old ChainID (1511670449). However the CI is failing for the deprecated chain ID (1511670449) since the ChainID doesn't match the chainID from the RPC (we don't have an RPC with the old chain ID). Please let me know what needs to be done for this situation, thank you and have a good day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants