Support content filters that only post a comment when a regex is not found #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophiederosa
changed the title
sophiederosa
changed the title
ethanis
reviewed
Jun 17, 2021
.github/nitpicks.yml
Outdated
Comment on lines
28
to
29
| contentFilter: | ||
| - '!always()' |
There was a problem hiding this comment.
Do you think non-matching content filters should be their own input? It might be a valid use case for one to want to match a string that does start with a ! 🤔
There was a problem hiding this comment.
yeah we can do it that way too! I personally felt like these were two sides of the same coin so it made sense to use contentFilter for both
There was a problem hiding this comment.
I'll run a test to see what '!(!always())' will do as a content filter
There was a problem hiding this comment.
That actually appears to work. I ran a test with this as the content filter:
contentFilter:
- '!(!always())'
with this as the yaml, it produced a comment:
if: 'always()'
with this as the yaml, it did not produce a comment:
if: '!always()'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example, I might want nitpicker to enforce that a regex is present in all .rb files such as "# frozen_string_literal: true". With this change you can specify
And a comment will only be posted if a file does not contain that regex.
Along with this PR I added a new example.yml file and a rule to the nitpicks.yml to test the change (I don't have permissions here but I tested it in my forked repo: https://github.com/sophiederosa/nitpicker/pull/1), I will delete that before it is merged in.