-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new interface in robustness tests #19137
base: main
Are you sure you want to change the base?
Use new interface in robustness tests #19137
Conversation
Hi @AwesomePatrol. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
65f0888
to
45b2933
Compare
/ok-to-test |
Signed-off-by: Aleksander Mistewicz <[email protected]>
Signed-off-by: Aleksander Mistewicz <[email protected]>
Signed-off-by: Aleksander Mistewicz <[email protected]>
Signed-off-by: Aleksander Mistewicz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 29 files with indirect coverage changes @@ Coverage Diff @@
## main #19137 +/- ##
==========================================
- Coverage 68.86% 68.73% -0.13%
==========================================
Files 420 420
Lines 35640 35640
==========================================
- Hits 24543 24498 -45
- Misses 9679 9712 +33
- Partials 1418 1430 +12 Continue to review full report in Codecov by Sentry.
|
/retest |
5c2fa44
to
8335e70
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AwesomePatrol, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Robustness tests now use
kubernetes.Interface
(where possible) replacing use ofkubernetesClient
(deleted)