Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new interface in robustness tests #19137

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AwesomePatrol
Copy link
Contributor

Robustness tests now use kubernetes.Interface (where possible) replacing use of kubernetesClient (deleted)

@k8s-ci-robot
Copy link

Hi @AwesomePatrol. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@AwesomePatrol AwesomePatrol force-pushed the use-new-interface-in-robustness-tests branch from 65f0888 to 45b2933 Compare January 7, 2025 15:49
@serathius
Copy link
Member

/ok-to-test

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (70a1726) to head (8335e70).
Report is 2 commits behind head on main.

Additional details and impacted files

see 29 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19137      +/-   ##
==========================================
- Coverage   68.86%   68.73%   -0.13%     
==========================================
  Files         420      420              
  Lines       35640    35640              
==========================================
- Hits        24543    24498      -45     
- Misses       9679     9712      +33     
- Partials     1418     1430      +12     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a1726...8335e70. Read the comment docs.

@serathius
Copy link
Member

/retest

@AwesomePatrol AwesomePatrol force-pushed the use-new-interface-in-robustness-tests branch from 5c2fa44 to 8335e70 Compare January 8, 2025 11:39
@AwesomePatrol

This comment was marked as outdated.

@AwesomePatrol AwesomePatrol marked this pull request as ready for review January 8, 2025 12:54
@AwesomePatrol

This comment was marked as outdated.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AwesomePatrol, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AwesomePatrol
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants