Skip to content

Commit

Permalink
Changed return type of ValidateAndReturnVisualize to return the entir…
Browse files Browse the repository at this point in the history
…e results struct
  • Loading branch information
VidhuSarwal committed Dec 21, 2024
1 parent bc166dd commit 65f9421
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions tests/robustness/validate/validate.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ import (
"go.etcd.io/etcd/tests/v3/robustness/report"
)

// ValidateAndReturnVisualize returns visualize as porcupine.linearizationInfo used to generate visualization is private.
func ValidateAndReturnVisualize(t *testing.T, lg *zap.Logger, cfg Config, reports []report.ClientReport, persistedRequests []model.EtcdRequest, timeout time.Duration) (visualize func(basepath string) error) {
func ValidateAndReturnVisualize(t *testing.T, lg *zap.Logger, cfg Config, reports []report.ClientReport, persistedRequests []model.EtcdRequest, timeout time.Duration) Results {
err := checkValidationAssumptions(reports, persistedRequests)
require.NoErrorf(t, err, "Broken validation assumptions")
linearizableOperations := patchLinearizableOperations(reports, persistedRequests)
Expand All @@ -38,7 +37,7 @@ func ValidateAndReturnVisualize(t *testing.T, lg *zap.Logger, cfg Config, report
linearizable, results := validateLinearizableOperationsAndVisualize(lg, linearizableOperations, timeout)
if linearizable != porcupine.Ok {
t.Error("Failed linearization, skipping further validation")
return results.Visualize
return results
}

// TODO: Use requests from linearization for replay.
Expand All @@ -52,7 +51,7 @@ func ValidateAndReturnVisualize(t *testing.T, lg *zap.Logger, cfg Config, report
if err != nil {
t.Errorf("Failed validating serializable operations, err: %s", err)
}
return results.Visualize
return results
}

type Config struct {
Expand Down

0 comments on commit 65f9421

Please sign in to comment.