Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing teardown to a few cloud tests #12044

Merged
merged 5 commits into from
Jan 14, 2025
Merged

Conversation

radeusgd
Copy link
Member

Pull Request Description

  • Every Temporary_Directory should have cleanup registered in the teardown of a test group: added 2 missing ones and a doc reminding to do that.
  • Tried automatically detecting missed ones but simple solution failed to work - not continuing for now.
  • Added Image_Tests to cloud test run as some data link integration tests are there.

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@radeusgd radeusgd added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 13, 2025
@radeusgd radeusgd self-assigned this Jan 13, 2025
@radeusgd radeusgd added the CI: Ready to merge This PR is eligible for automatic merge label Jan 14, 2025
@mergify mergify bot merged commit 8a28671 into develop Jan 14, 2025
48 of 50 checks passed
@mergify mergify bot deleted the wip/radeusgd/fix-cloud-clean branch January 14, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants