Implementation of customisation settings secondary navbar #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Used placeholder images for the brandbar at the top. Not sure where the assets are on my side. |
luukee
reviewed
Feb 19, 2025
There was a problem hiding this comment.
@DavidLungu Everything looks great! A couple small notes.
What about creating a ACF for the link URL for the Texas Moody logo in the brandbar?
There was a problem hiding this comment.
Also, you might want to check the vertical alignment of the brandbar logos.
There was a problem hiding this comment.
Not too sure what's going on with the logo there. On my part, everything seems to be fine.
There was a problem hiding this comment.
Might be something on my install or logo images that are different. We can push it to the dev site and see how it looks. Thanks David 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#375