Skip to content

Commit

Permalink
medEng docs sm edits
Browse files Browse the repository at this point in the history
  • Loading branch information
luukee committed Sep 5, 2024
1 parent 2e3e694 commit a7acc4d
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 12 deletions.
30 changes: 19 additions & 11 deletions _posts/2023-05-20-mediaengagement-technical-docs.md
Original file line number Diff line number Diff line change
Expand Up @@ -525,17 +525,25 @@ After your code is reviewed:
</td>
<td>master
</td>
<td>Accepts merges from Features/Issues and Hotfixes
<td>Accepts merges from Features/Issues, Bugs and Hotfixes
</td>
</tr>
<tr>
<td>Features/Issues
</td>
<td>topic-*
<td>feature-*
</td>
<td>Always branch off HEAD of Working
</td>
</tr>
<tr>
<td>Bug
</td>
<td>bug-*
</td>
<td>Always branch off Working
</td>
</tr>
<tr>
<td>Hotfix
</td>
Expand Down Expand Up @@ -625,25 +633,25 @@ Although likelihood will be less, during the lifespan of the bug development, th
If the branch does not exist yet (check with the Lead), create the branch locally and then push to GitHub. A bug branch should always be 'publicly' available. That is, development should never exist in just one developer's local branch.

```
$ git checkout -b bug-id master // creates a local branch for the new bug
$ git push origin bug-id // makes the new bug remotely available
$ git checkout -b bug-id master // creates a local branch for the new bug
$ git push origin bug-id // makes the new bug remotely available
```

Periodically, changes made to `master` (if any) should be merged back into your bug branch.


```
$ git merge master // merges changes from master into bug branch
$ git merge master // merges changes from master into bug branch
```


When development on the bug is complete, [the Lead] should merge changes into `master` and then make sure the remote branch is deleted.

```
$ git checkout master // change to the master branch
$ git merge --no-ff bug-id // makes sure to create a commit object during merge
$ git push origin master // push merge changes
$ git push origin :bug-id // deletes the remote branch
$ git checkout master // change to the master branch
$ git merge --no-ff bug-id // makes sure to create a commit object during merge
$ git push origin master // push merge changes
$ git push origin :bug-id // deletes the remote branch
```

### Hotfix Branches
Expand All @@ -665,8 +673,8 @@ ___
If the branch does not exist yet (check with the Lead), create the branch locally and then push to GitHub. A hotfix branch should always be 'publicly' available. That is, development should never exist in just one developer's local branch.

```
$ git checkout -b hotfix-id stable // creates a local branch for the new hotfix
$ git push origin hotfix-id // makes the new hotfix remotely available
$ git checkout -b hotfix-id stable // creates a local branch for the new hotfix
$ git push origin hotfix-id // makes the new hotfix remotely available
```

When development on the hotfix is complete, [the Lead] should merge changes into `stable` and then update the tag.
Expand Down
3 changes: 2 additions & 1 deletion _posts/2023-05-21-mediaengagement.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ location ~ ^/wp-content/uploads/(.*) {
git fetch --all
git reset --hard origin/master
```

For more detail see [Technical Docs - Sync with GitHub](mediaengagement-technical-docs/#syncing-with-github)
---

## Local Development
Expand Down Expand Up @@ -140,6 +140,7 @@ npm run production

### Git Usage
- Always create separate branches for new features or bug fixes.
- For more detail see [Technical Docs - Sync with GitHub](/mediaengagement-technical-docs/#git-usage)
- Push to the `master` branch only after code review and testing.

For more detailed Git workflows, see [Deployment Workflow](#deployment-workflow).
Expand Down

0 comments on commit a7acc4d

Please sign in to comment.