Add make_precompiler_downloader option #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjyoungblood
force-pushed
the
custom-downloader
branch
from
fb00d47 to
b1ba146
Compare
josevalim
reviewed
May 8, 2024
test/mix/tasks/compile.make_test.exs
Outdated
| cache_dir = "./cache" | ||
| System.put_env("ELIXIR_MAKE_CACHE_DIR", cache_dir) | ||
|
|
||
| Mix.Task.reenable("elixir_make.precompile") |
There was a problem hiding this comment.
Do we need to reenable it here again since we reenable on setup?
josevalim
reviewed
May 8, 2024
test/mix/tasks/compile.make_test.exs
Outdated
| [ | ||
| make_precompiler: {:nif, MyApp.Precompiler}, | ||
| make_precompiler_url: "https://example.com/@{artefact_filename}", | ||
| make_precompile_downloader: MyApp.Downloader |
There was a problem hiding this comment.
Perhaps it makes more sense to define this module on this file?
|
Looks good to me. Can you please rename the option to |
Allows users to customize download behavior, such as adding HTTP authentication or using an alternate protocol like SFTP.
bjyoungblood
force-pushed
the
custom-downloader
branch
from
b1ba146 to
14a2b7b
Compare
|
Thanks for the review! I've updated the PR with your suggestions. |
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to customize download behavior, such as adding HTTP
authentication or using an alternate protocol like SFTP.