Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ShellClients support #749

Merged
merged 9 commits into from
Sep 13, 2024
Merged

Add ShellClients support #749

merged 9 commits into from
Sep 13, 2024

Conversation

danirabbit
Copy link
Member

Fixes #748

This doesn't fix that the panel takes a hella long time to start in the Greeter for some reason, but it does fix the positioning!

@danirabbit danirabbit requested a review from a team August 16, 2024 21:37
@leolost2605
Copy link
Member

Not sure do we want the full thing here or only for wingpanel? If only wingpanel we can strip this down a whole lot.
(E.g. remove Barrier.vala, CenteredWindow.vala, HideTracker.vala, NotificationsClient.vala (This can and probably should be removed anyways) and a whole lot of code). I can do the strip if you want but I haven't worked with greeter compositor yet so I'm not sure about the integration. Although it seems to be just a frankensteined version of gala I guess :)

Also which config file is used here to start the wayland clients when running under wayland? (Does greeter even support wayland yet 😬 ?)

@danirabbit
Copy link
Member Author

@leolost2605 Yeah I was wondering if it made sense to strip it down or if it was better to keep it so we can keep it in sync with Gala updates? I think we want notifications for the volume and brightness confirmations right?

I just hardcoded the panel here in the area of which things to launch. But no I don't think the greeter session supports wayland? I think we need to keep it X11 for a11y

@danirabbit
Copy link
Member Author

danirabbit commented Aug 27, 2024

@leolost2605 I removed Barrier and HideTracker since those are unused by the panel, but I left in Center and Notifications because I'd like to use center for installer and initial setup and it's used for the session dialog and I think we do want notifications for indicator confirmations at least

@leolost2605
Copy link
Member

I think we want notifications for the volume and brightness confirmations right?

Ah right I forgot about that 😅

With the removal of HideTracker I guess we probably should also remove the corresponding protocol methods?
Apart from that I guess this should be fine but maybe someone who knows the whole greeter structure and stuff better than me can confirm :)

@danirabbit
Copy link
Member Author

I guess that would be maybe @tintou or @lenemter ?

@lenemter
Copy link
Member

@danirabbit I don't think we should modify the protocol file (protocol/pantheon-desktop-shell-v1.xml) here in any way. Instead we can just ignore the options we don't require or use yet.

@danirabbit
Copy link
Member Author

@lenemter done!

@danirabbit danirabbit merged commit 66d77d7 into master Sep 13, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/shellclients branch September 13, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add dock/panel positioning to greeter compositor
4 participants