-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ShellClients support #749
Conversation
Not sure do we want the full thing here or only for wingpanel? If only wingpanel we can strip this down a whole lot. Also which config file is used here to start the wayland clients when running under wayland? (Does greeter even support wayland yet 😬 ?) |
@leolost2605 Yeah I was wondering if it made sense to strip it down or if it was better to keep it so we can keep it in sync with Gala updates? I think we want notifications for the volume and brightness confirmations right? I just hardcoded the panel here in the area of which things to launch. But no I don't think the greeter session supports wayland? I think we need to keep it X11 for a11y |
@leolost2605 I removed Barrier and HideTracker since those are unused by the panel, but I left in Center and Notifications because I'd like to use center for installer and initial setup and it's used for the session dialog and I think we do want notifications for indicator confirmations at least |
Ah right I forgot about that 😅 With the removal of HideTracker I guess we probably should also remove the corresponding protocol methods? |
@danirabbit I don't think we should modify the protocol file (protocol/pantheon-desktop-shell-v1.xml) here in any way. Instead we can just ignore the options we don't require or use yet. |
@lenemter done! |
Fixes #748
This doesn't fix that the panel takes a hella long time to start in the Greeter for some reason, but it does fix the positioning!