Skip to content

Commit

Permalink
fix flaky integration test
Browse files Browse the repository at this point in the history
  • Loading branch information
miguelgrinberg committed Jan 29, 2025
1 parent 3ee42ad commit 8f63a6f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import pytest

from elasticsearch import AsyncElasticsearch
from test_elasticsearch.test_dsl.async_sleep import sleep

from ..async_examples import vectors

Expand All @@ -48,9 +47,6 @@ def encode(self, text: str) -> List[float]:
mocker.patch.object(vectors, "SentenceTransformer", new=MockModel)

await vectors.create()
for i in range(10):
results = await (await vectors.search("Welcome to our team!")).execute()
if len(results.hits) > 0:
break
await sleep(0.1)
await vectors.WorkplaceDoc._index.refresh()
results = await (await vectors.search("Welcome to our team!")).execute()
assert results[0].name == "New Employee Onboarding Guide"
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import pytest

from elasticsearch import Elasticsearch
from test_elasticsearch.test_dsl.sleep import sleep

from ..examples import vectors

Expand All @@ -48,9 +47,6 @@ def encode(self, text: str) -> List[float]:
mocker.patch.object(vectors, "SentenceTransformer", new=MockModel)

vectors.create()
for i in range(10):
results = (vectors.search("Welcome to our team!")).execute()
if len(results.hits) > 0:
break
sleep(0.1)
vectors.WorkplaceDoc._index.refresh()
results = (vectors.search("Welcome to our team!")).execute()
assert results[0].name == "New Employee Onboarding Guide"

0 comments on commit 8f63a6f

Please sign in to comment.