-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI]: retry with sleep #20065
[CI]: retry with sleep #20065
Conversation
This pull request doesn't have a |
@@ -947,7 +947,9 @@ def withBeatsEnv(Map args = [:], Closure body) { | |||
if (archive) { | |||
archiveTestOutput(testResults: '**/build/TEST*.xml', artifacts: '**/build/TEST*.out') | |||
} | |||
reportCoverage() | |||
catchError(buildResult: 'SUCCESS', stageResult: 'UNSTABLE') { | |||
sh(label: 'Report to Codecov', script: '.ci/scripts/report-codecov.sh auditbeat filebeat heartbeat journalbeat libbeat metricbeat packetbeat winlogbeat') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the codecov step from the library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uhm, that's a good point, my aim was to add more resilience to the 4xx http errors when curling the codecov... so I'll iterate a few times and see if we can simplify the pipeline to use the steps as you said
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've just raised an issue #20080 to fix the the codecov issues in the pipeline since the credentials are not in place as far as I see, so for the time being I'll keep this PR as is and I'll work on the issue afterwards
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
What does this PR do?
Use retry with sleep step and refactored the codecov step with more resiliance using the CI worker utils script.
Why is it important?
Avoid the issues when codecov is not reachable:
Issues
See codecov/codecov-python#158