-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promote dev build to master #405
Open
alexwaibel
wants to merge
9
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Convert error handler to more modern class declaration. * Make GitHub and GitService actually throw errors rather than return them * Fix some broken unit and acceptance tests
Add automatic Swagger API documentation generated from jsdoc comments.
…mails, something other than "Staticman". (#393) - Added email.fromName to the JSON config schema. - Updated config schema doc to remove reference to non-existent notifications.fromAddress parameter in the site config. - Updated unit test.
* Rework project structure with directories for source and config * Upgrade Standard to latest and resolve style errors * Upgrade jest to latest version * Add babel support and convert to modern import syntax * Utilize spread operator in place of object assign * Bump convict version to latest to resolve security issue. * Bump node version
* Rework project structure with new source and config directories * Upgrade Jest and Standard to latest and resolve errors * Add basic babel config and use modern import/export syntax * Bump convict version to latest to resolve security issue. * Bump Travis node version * Configure ESLint and Prettier and resolve all style errors * Consolidate some config files into package json * Add basic GitHub codespaces config files
This reverts commit 3bb3c31.
* Implemented OneDev service. * Updated for latest OneDev api changes. * Added config documentation. * Added tests for OneDev. * Added suggestions.
freininghaus
added a commit
to freininghaus/staticman
that referenced
this pull request
Feb 20, 2022
The current master branch allows authorization via the GITHUB_TOKEN option only for v1 and v2. The dev branch contains a fix for this, eduardoboucas@1f31ac8 but the pull request has been open for quite some time, eduardoboucas#405 Unfortunately, the dev branch does not seem to work out of the box for me, so I will just use this small patch to make Staticman work for me for the time being.
Is this project abandoned? 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should bump the master branch with the latest dev changes. Notably, this release includes