Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes title of SSJ example more informative #1509

Merged
merged 16 commits into from
Jan 8, 2025

Conversation

akshayshanker
Copy link
Collaborator

@akshayshanker akshayshanker commented Nov 6, 2024

Do not merge yet.

SSJ example -> HANK Fiscal Policy

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@akshayshanker akshayshanker marked this pull request as ready for review November 15, 2024 19:53
Akshay changed the name of the file, but the old file lingered. Deleting.
@mnwhite
Copy link
Contributor

mnwhite commented Nov 15, 2024

A toc file needs to be updated now that the filename has changed.

@llorracc
Copy link
Collaborator

llorracc commented Dec 9, 2024

@akshayshanker,

Apparently there's a problem with the docs. Could you see if you can fix? If not ask Matt or Alan for help.

@alanlujan91 alanlujan91 self-assigned this Dec 11, 2024
@akshayshanker
Copy link
Collaborator Author

Finally fixed the toc tests. @mnwhite , can you please review and merge if OK.

@mnwhite mnwhite merged commit da3442e into econ-ark:master Jan 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants