Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add plugins and partial mixins unit test #746

Merged
merged 3 commits into from
Nov 19, 2020
Merged

test: add plugins and partial mixins unit test #746

merged 3 commits into from
Nov 19, 2020

Conversation

Phinome
Copy link
Contributor

@Phinome Phinome commented Nov 17, 2020

detail:

  • add test of plugins
  • add partial test of mixins
  • update eslint to fix unit test

#433

detail:
- add test of plugins
- add partial test of mixins
- update eslint to fix unit test
@Phinome Phinome linked an issue Nov 17, 2020 that may be closed by this pull request
95 tasks
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #746 (2c8e81e) into d20 (37d5933) will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              d20     #746      +/-   ##
==========================================
- Coverage   76.10%   75.86%   -0.25%     
==========================================
  Files         181      182       +1     
  Lines        6421     6430       +9     
  Branches     1351     1351              
==========================================
- Hits         4887     4878       -9     
- Misses       1059     1077      +18     
  Partials      475      475              
Impacted Files Coverage Δ
packages/veui/src/mixins/dropdown.js 36.00% <0.00%> (-24.00%) ⬇️
packages/veui/src/utils/dom.js 59.40% <0.00%> (-4.43%) ⬇️
packages/veui/src/mixins/key-select.js 91.37% <0.00%> (-1.73%) ⬇️
packages/veui/src/utils/plugin.js 100.00% <0.00%> (ø)
packages/veui/src/mixins/activatable.js 100.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37d5933...2c8e81e. Read the comment docs.

detail:
- add test of plugins
- add partial test of mixins
- update eslint to fix unit test
@Justineo
Copy link
Member

@Phinome 如果 ready to merge 了,需要改一下 PR 状态,现在是 Draft。

@Phinome Phinome marked this pull request as ready for review November 19, 2020 10:11
@Phinome Phinome requested a review from Justineo November 19, 2020 10:15
@Justineo Justineo merged commit f26623d into d20 Nov 19, 2020
@Justineo Justineo deleted the test_unit branch November 19, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

单测补完
2 participants