Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken print on devel #6762

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Fix broken print on devel #6762

merged 3 commits into from
Feb 6, 2025

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Jan 26, 2025

nuxt.config.js: add print to allowed hosts

This somehow was an issue locally now.


vueI18nConfig.js: fallbackLocale.default now needs to be an array

This fixes:
fallback[locale].filter is not a function or its return value is not iterable

Fixes #6761


frontend/print/pdf: switch from lodash to lodash-es

Print had a problem loading lodash.
Because we use lodash in common, i switched all modules.
This fixes the dev mode of print.
cjs lodash is still used transitively by some dev packages,
but that's ok.

@BacLuc BacLuc added the deploy! Creates a feature branch deployment for this PR label Jan 26, 2025
@BacLuc BacLuc requested a review from a team January 26, 2025 13:45
Copy link

github-actions bot commented Jan 26, 2025

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@BacLuc BacLuc requested a review from carlobeltrame January 28, 2025 19:51
@BacLuc BacLuc requested a review from a team February 6, 2025 19:48
This somehow was an issue locally now.
This fixes:
fallback[locale].filter is not a function or its return value is not iterable

Fixes ecamp#6761
Print had a problem loading lodash.
Because we use lodash in common, i switched all modules.
This fixes the dev mode of print.
cjs lodash is still used transitively by some dev packages,
but that's ok.
@BacLuc BacLuc enabled auto-merge February 6, 2025 20:03
@BacLuc BacLuc added this pull request to the merge queue Feb 6, 2025
Merged via the queue into ecamp:devel with commit d0b10bc Feb 6, 2025
31 checks passed
@BacLuc BacLuc deleted the fix-print branch February 6, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

print broken on devel
4 participants