Server: Delta snapshot developer print fix #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Add deltaActive client variable to indicate whether delta snapshots are enabled, instead of relying on whether deltaMessage value is in range. Allows developer prints to correctly distinguish between delta being disabled intentionally versus by PACKET_BACKUP limit.
Chomenor
force-pushed
the
delta_print_fix
branch
from
ca6e680 to
7b0787d
Compare
|
I changed it to use a separate variable to hold whether delta snapshots are active. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3f92ee4 client->deltaMessage is set to
client->netchan.outgoingSequence - (PACKET_BACKUP + 1)as a way to disable delta snapshots. Developer warnings like "Delta request from out of date packet" are not printed when client->deltaMessage matches this exact expression, but asclient->netchan.outgoingSequenceis incremented, warning messages may be printed when they shouldn't be.This fix restores the behavior that client->deltaMessage is set to -1 to disable delta snapshots, allowing developer prints to correctly distinguish between delta being disabled intentionally versus by PACKET_BACKUP limit.