-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: create Ratio and use it for aspectRatio and displayAspectRatio and frameRate #336
base: dev
Are you sure you want to change the base?
Conversation
Thank you @MarcAntoine-Arnaud ! |
owl:onDataRange xsd:integer ; | ||
xsd:minInclusive 1 | ||
] ; | ||
dcterms:description "Represent a ratio of values."@en , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo : Represents
owl:minQualifiedCardinality "1"^^xsd:nonNegativeInteger ; | ||
owl:maxQualifiedCardinality "1"^^xsd:nonNegativeInteger ; | ||
owl:onDataRange xsd:integer ; | ||
xsd:minInclusive 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about the restriction : xsd:minInclusive 1
Don't you think you should encapsulate this restriction within a datatype definition ? To be OWL 2 compliant ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long review time! During our last Editorial Committee meeting we have concluded to pack this into a new issue and use a new class Ratio
for two of the three attributes mentioned above. I have now re-analysed the comments and would also use it for the Attribute frameRate
.
But as I am starting to do this, I am stumbling across this question of aro-max. What do you think, @MarcAntoine-Arnaud ? Should you encapsulate the restriction within a datatype definitrion as proposed by @aro-max ? If we can resolve this question quickly, I might be able to review, merge and commit your pull request quickly as well.
Currently the property |
Editorial Committee:
Conclusion: we will create a separate issue on that |
issue #332