correction of the shap explainer and refactoring

eXascaleInfolab · Sep 25, 2024 · 95b67de · 95b67de
1 parent b2abe47
commit 95b67de
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/.idea/workspace.xml b/.idea/workspace.xml
diff --git a/imputegap/explainer/explainer.py b/imputegap/explainer/explainer.py
@@ -130,11 +130,11 @@ def convert_results(tmp, file, algo, descriptions, features, categories, mean_fe
         :param categories: Category of each feature
         :param mean_features: Mean values of each feature
         :param to_save : path to save results
-        :return: Perfect diplay for SHAP result
+        :return: Perfect display for SHAP result
         """
-        result_display, display_details, result_shap = [], [], []
+        result_display, result_shap = [], []
         for x, rate in enumerate(tmp):
-            if math.isnan(rate) == False:
+            if not math.isnan(rate):
                 rate = float(round(rate, 2))
 
             result_display.append((x, algo, rate, descriptions[0][x], features[0][x], categories[0][x], mean_features[x]))

diff --git a/tests/assets/shap/chlorine_cdrec_shap_plot.png b/tests/assets/shap/chlorine_cdrec_shap_plot.png