-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Devcontainer support #523
Conversation
PowerShell install example
Works with VSCode. |
Hello, Thank you for your contribution.
I'm not closed to the idea.. let's talk it over with @dunglas |
Thank you @maxhelias, some input on the points brought up:
All changes are under ".devcontainer" and ".vscode", I don't think it adds significant complexity and it's completely optional.
This is true.
Theoretically, it's an open standard https://containers.dev/. Practically works in VSCode and should work in PhpStorm but it's pretty now in PhpStorm so looks like there are some bugs at the moment. As you can see it was reported less than a month ago https://youtrack.jetbrains.com/issue/IDEA-337397/DevContainers.-Creating-fails-for-alpine-images. if this is a blocker we can maybe wait for it to be fixed.
Should be compatible. also compatible with extra containers setup like in the api-platform template. |
Hello, With the complexity of maintenance that this integration would add and to the lack of knowledge of this subject, I'd rather not include it in the project. Thank you for your proposal. |
Copy of api-platform/api-platform#2488 (without the folder change as it's not needed here)