Set OCAMLTOP_INCLUDE_PATH (as in ocaml.5.3.*)
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbuenzli
reviewed
Jan 28, 2025
| [OCAML_TOPLEVEL_PATH = "%{toplevel}%"] | ||
| ] | ||
| x-env-path-rewrite: [ | ||
| [CAML_LD_LIBRARY_PATH (";" {os = "win32"} ":" {os != "win32"}) "target"] | ||
| [OCAMLTOP_INCLUDE_PATH (";" {os = "win32"} ":" {os != "win32"}) "target"] |
There was a problem hiding this comment.
Any reason why you don't do this for OCAML_TOPLEVEL_PATH ?
There was a problem hiding this comment.
It's not a PATH-like variable - it's only ever set using =
|
Unfortunately this does also trigger a rebuild of the |
|
That's not really different from a dune update :–) |
|
looks ok to me (although I don't have time to try to reproduce the conditions in which this is an issue) |
dra27
force-pushed
the
deploy-fix-25819
branch
from
b0632fd to
e30e484
Compare
OCAML_TOPLEVEL_PATH is left for now as ocamlfind's stub still uses it.
dra27
force-pushed
the
deploy-fix-25819
branch
from
e30e484 to
88f3b38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of the setting of
OCAMLTOP_INCLUDE_PATHwhich was trialled with ocaml#26594.4.08.0 is the first version of the compiler supporting this environment variable. Updating the remaining packages mitigates the issue seen in dbuenzli/topkg#142 and reported in ocaml#25819 (comment).
Opened here for review, as the revdeps testing impact is obviously quite large...