Fix Potential Crash in Fluent High Contrast #10229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
requested review from
dipeshmsft,
singhashish-wpf and
Kuldeep-MS
dotnet-policy-service
bot
added
the
PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The theme generator for
Fluentthemes partially relies on common brushes, colors, and keys written in theme files, i.e.Light.xaml,Dark.xamlandHC.xaml. The current implementation ofHC.xamlcontains a duplication ofSystemColorWindowColorkey.The resource dictionary loaded at runtime for High Contrast theme is Fluent.HC.xaml, which right now is correct but if/when we generate the same, it will result in duplication of that key and hence runtime crashing of applications on high contrast theme.
Customer Impact
Fixes any future regression and crash on high contrast theme (Fluent)
Testing
Local Build Pass
Risk
Low, removal of a xaml key.
Does not violate API contract as the key is already present.
Microsoft Reviewers: Open in CodeFlow