Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage for public API surface of DurationConverter #10226

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

h3xds1nz
Copy link
Contributor

@h3xds1nz h3xds1nz commented Jan 5, 2025

Description

Adds test coverage for DurationConverter. Both the original and my PR #9768 have been tested against this.

Customer Impact

Improved test coverage on public surface.

Regression

No.

Testing

Local build.

Risk

None.

Microsoft Reviewers: Open in CodeFlow

@h3xds1nz h3xds1nz requested review from a team as code owners January 5, 2025 13:43
@dotnet-policy-service dotnet-policy-service bot added PR metadata: Label to tag PRs, to facilitate with triage Community Contribution A label for all community Contributions labels Jan 5, 2025
@singhashish-wpf
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@singhashish-wpf singhashish-wpf merged commit f28e503 into dotnet:main Jan 6, 2025
8 checks passed
@singhashish-wpf
Copy link
Member

Thanks @h3xds1nz

@h3xds1nz
Copy link
Contributor Author

h3xds1nz commented Jan 6, 2025

@singhashish-wpf Thanks as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution A label for all community Contributions PR metadata: Label to tag PRs, to facilitate with triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants