Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/9.0.2xx] Update dependencies from nuget/nuget.client #46296

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 25, 2025

Part of #40913.

Description

This PR updates the implementation of dotnet list package and dotnet why to support using slnx-formatted solution files as the input arguments. Today those commands only support sln files, which could lead to a user experience cliff if those commands are used in the 9.0.2xx CLI alongside all of the rest of the slnx-related updates we've done to the CLI.

Customer Impact

Customers using the 9.0.200 SDK to convert and onboard to slnx support everywhere will not be able to inspect their solutions for outdated packages, or use CLI tooling to discover where a given package or package version is being pulled into their dependency graph.

User-reported

No

Risk

Low - the scope of the change was to two CLI-only commands, no Visual Studio or NuGet.exe experiences are impacted by this change.

Testing

New automated tests were added that verify slnx and sln support for the two commands impacted. In addition, @baronfel did manual testing of the commands on a sample set of slnx-containing repos.

This pull request updates the following dependencies

From https://github.com/nuget/nuget.client

  • Subscription: a8a96eea-7948-4ef9-bb5a-debaa65eb629
  • Build: 6.13.1.1
  • Date Produced: January 25, 2025 1:47:11 AM UTC
  • Commit: 3d42754f2962b30deac1ec48e5415aa83c071b37
  • Branch: release-6.13.x

…6.13.1.1

Microsoft.Build.NuGetSdkResolver , NuGet.Build.Tasks , NuGet.Build.Tasks.Console , NuGet.Build.Tasks.Pack , NuGet.CommandLine.XPlat , NuGet.Commands , NuGet.Common , NuGet.Configuration , NuGet.Credentials , NuGet.DependencyResolver.Core , NuGet.Frameworks , NuGet.LibraryModel , NuGet.Localization , NuGet.Packaging , NuGet.ProjectModel , NuGet.Protocol , NuGet.Versioning
 From Version 6.13.0-rc.113 -> To Version 6.13.1-rc.1
@baronfel
Copy link
Member

Approved, but waiting for branding for March's releases before merge.

…darc-release/9.0.2xx-cbc025dc-be7f-44e3-b778-35550b2d836d
@v-wuzhai v-wuzhai merged commit b4a2299 into release/9.0.2xx Feb 6, 2025
26 of 31 checks passed
@v-wuzhai v-wuzhai deleted the darc-release/9.0.2xx-cbc025dc-be7f-44e3-b778-35550b2d836d branch February 6, 2025 08:05
@kasperk81
Copy link
Contributor

New automated tests were added that verify slnx and sln support for the two commands impacted. In addition, @baronfel did manual testing of the commands on a sample set of slnx-containing repos.

how was it tested? it doesn't have NuGet/NuGet.Client@20096ab and slnx changes were missed in 9.0.200

@baronfel
Copy link
Member

This is the code flow for 9.0.201 next month, where the slnx support is fixed for these two commands

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants