Poolable / Resettable CBOR Readers #88104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-formats-cbor, @bartonjs, @vcsjones Issue DetailsClose #67868 issue.
|
adamsitnik
reviewed
Jul 6, 2023
There was a problem hiding this comment.
Overall the changes look very good, I left some comments with minor improvement suggestions. @AlexRadch PTAL
Thank you for your contribution!
src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/Reader/CborReader.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/Reader/CborReader.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Formats.Cbor/tests/Reader/CborReaderTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Formats.Cbor/tests/Reader/CborReaderTests.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Jul 6, 2023
…er/CborReader.cs Co-authored-by: Adam Sitnik <[email protected]>
Co-authored-by: Adam Sitnik <[email protected]>
Co-authored-by: Adam Sitnik <[email protected]>
Co-authored-by: Adam Sitnik <[email protected]>
bartonjs
reviewed
Jul 10, 2023
src/libraries/System.Formats.Cbor/src/System/Formats/Cbor/Reader/CborReader.cs
Outdated
Show resolved
Hide resolved
…er/CborReader.cs Co-authored-by: Jeremy Barton <[email protected]>
This was referenced Jul 10, 2023
adamsitnik
approved these changes
Jul 17, 2023
|
The CI failure is unrelated (#86019) |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #67868 issue.