Fix a typo in UnixNativeCodeManager.cpp #111103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I6ae5074b310611955dc8a95fb9c67223af7a25f1
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
|
@agocke please have a look. |
|
This is included in #111086 |
jkotas
reviewed
Jan 6, 2025
| @@ -1248,7 +1248,7 @@ bool UnixNativeCodeManager::GetReturnAddressHijackInfo(MethodInfo * pMethodIn | |||
| } | |||
|
|
|||
| *ppvRetAddrLocation = (PTR_PTR_VOID)pRegisterSet->pLR; | |||
| #elif | |||
| #else | |||
There was a problem hiding this comment.
The code is identical between the #if and #else, except for the register name.
Would it be better to add delete this ifdef and add a helper method method to LoongArch and Arm reg displays to abstract away the difference?
inline uintptr_t* GetReturnAddressRegisterLocation() { return pLR; }
...
inline uintptr_t* GetReturnAddressRegisterLocation() { return pRA; }
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a typo introduced from #110799.
@shushanhf @LuckyXu-HF