[Windows] Fix for FontImageSource color is not applied to the Tab Icon on the TabbedPage #26888
+46
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Tamilarasan-Paranthaman
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
reviewed
Jan 14, 2025
| @@ -325,6 +357,7 @@ internal static void MapItemsSource(ITabbedViewHandler handler, TabbedPage view) | |||
| (vm, page) => | |||
| { | |||
| vm.Icon = page.IconImageSource?.ToIconSource(handler.MauiContext!)?.CreateIconElement(); | |||
| vm.IconColor = (page.IconImageSource as FontImageSource)?.Color?.AsPaint()?.ToPlatform(); | |||
There was a problem hiding this comment.
Could include an UITest and validate the colors with the VerifyScreenshot method?
There was a problem hiding this comment.
The test case has already been added to the following PR. We can re-enable it for Windows once the PR has been merged.
PR : #26757
Or Do I need to add the same test case in this PR as well?
There was a problem hiding this comment.
Yes, in this PR, remove the #if TEST_FAILS_ON_WINDOWS compilation directive from the FontImageSourceColorShouldApplyOnTabIcon test and commit the snapshot to validate the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
Description of Change
Issues Fixed
Fixes #26752
Test Case
Tested the behaviour in the following platforms
Screenshot